src: simplify TCPWrap::Connect signature#62929
Open
addaleax wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Just a little piece of cleanup -- this aligns `TCPWrap::Connect` with its sibling `TCPWrap::Bind`, deduplicates code and removes an unnecessary heap allocation. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
santigimeno
approved these changes
Apr 24, 2026
addaleax
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
daeyeon
approved these changes
Apr 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62929 +/- ##
==========================================
- Coverage 89.63% 89.63% -0.01%
==========================================
Files 706 706
Lines 219219 219212 -7
Branches 42004 42000 -4
==========================================
- Hits 196499 196489 -10
- Misses 14622 14630 +8
+ Partials 8098 8093 -5
🚀 New features to boost your workflow:
|
addaleax
added
the
commit-queue
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a little piece of cleanup -- this aligns
TCPWrap::Connectwith its siblingTCPWrap::Bind, deduplicates code and removes an unnecessary heap allocation.